Repository navigation
deps: update dependency com.google.googlejavaformat:google-java-format to v1.37.0 - #5006
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the google-java-format dependency version to 1.37.0 across multiple pom.xml files. The reviewer identified several compatibility issues because google-java-format 1.37.0 requires JDK 21 or higher. Some modules and samples are configured for JDK 11 or 17, which will cause build failures. It is recommended to update the profile activations or wrap the plugin configurations in JDK 21+ profiles to ensure compatibility.
| <groupId>com.google.googlejavaformat</groupId> | ||
| <artifactId>google-java-format</artifactId> | ||
| <version>1.28.0</version> | ||
| <version>1.37.0</version> |
There was a problem hiding this comment.
The google-java-format version 1.37.0 requires JDK 21 or higher to run. However, the format profile in this pom.xml is currently configured to activate on JDK 17 and above (<jdk>[17,)</jdk> at line 61). Running the build on JDK 17 will fail with an UnsupportedClassVersionError. Please update the profile activation to <jdk>[21,)</jdk> to match the JDK 21 requirement of the new google-java-format version.
| <groupId>com.google.googlejavaformat</groupId> | ||
| <artifactId>google-java-format</artifactId> | ||
| <version>1.36.1</version> | ||
| <version>1.37.0</version> |
There was a problem hiding this comment.
The google-java-format version 1.37.0 requires JDK 21 or higher to run. However, this project targets Java 11 (<java.version>11</java.version>) and the fmt-maven-plugin is configured directly in the main <build> section, meaning it will run by default on any JDK used to build the project. If built using JDK 11, the build will fail.\n\nTo prevent this, wrap the fmt-maven-plugin configuration in a profile that is only activated on JDK 21 or higher, similar to how it is done in the root pom.xml.
| <groupId>com.google.googlejavaformat</groupId> | ||
| <artifactId>google-java-format</artifactId> | ||
| <version>1.36.1</version> | ||
| <version>1.37.0</version> |
There was a problem hiding this comment.
The google-java-format version 1.37.0 requires JDK 21 or higher to run. However, this project targets Java 17 (<java.version>17</java.version>) and the fmt-maven-plugin is configured directly in the main <build> section. If built using JDK 17, the build will fail.\n\nPlease wrap the fmt-maven-plugin configuration in a profile that is only activated on JDK 21 or higher (e.g., <jdk>[21,)</jdk>), similar to the root pom.xml configuration.
| <groupId>com.google.googlejavaformat</groupId> | ||
| <artifactId>google-java-format</artifactId> | ||
| <version>1.28.0</version> | ||
| <version>1.37.0</version> |
There was a problem hiding this comment.
The google-java-format version 1.37.0 requires JDK 21 or higher to run. However, this project targets Java 17 (<java.version>17</java.version>) and the fmt-maven-plugin is configured directly in the main <build> section. If built using JDK 17, the build will fail.\n\nPlease wrap the fmt-maven-plugin configuration in a profile that is only activated on JDK 21 or higher (e.g., <jdk>[21,)</jdk>), similar to the root pom.xml configuration.
a14f693 to
ebe30d6
Compare
ebe30d6 to
ebd2ad2
Compare
This PR contains the following updates:
1.28.0→1.37.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
google/google-java-format (com.google.googlejavaformat:google-java-format)
v1.37.0Compare Source
Changes:
--max-line-lengthflag (#425)c51d691,ecba4fb)--google-styleand--style=google|aospflags for easier switching between Google and AOSP style (#1415)Full Changelog: google/google-java-format@v1.36.1...v1.37.0
v1.36.1What's Changed
Full Changelog: google/google-java-format@v1.36.0...v1.36.1
v1.36.0Changes:
Full Changelog: google/google-java-format@v1.35.0...v1.36.0
v1.35.0Changes:
075e025)Full Changelog: google/google-java-format@v1.34.1...v1.35.0
v1.34.1Changes:
Full Changelog: google/google-java-format@v1.34.0...v1.34.1
v1.34.0Changes:
Full Changelog: google/google-java-format@v1.33.0...v1.34.0
v1.33.0This release contains no formatting changes.
The constructors of the
com.google.googlejavaformat.java.filer.FormattingFilerAPI are now deprecated, and the new factory methodFormattingFiler#create(ProcessingEnvironment)should be used instead.Full Changelog: google/google-java-format@v1.32.0...v1.33.0
v1.32.0Changes:
Full Changelog: google/google-java-format@v1.31.0...v1.32.0
v1.31.0This release contains no formatting changes.
Changes:
SnippetFormatter(JavaFormatterOptions)constructor (8c30268)Full Changelog: google/google-java-format@v1.30.0...v1.31.0
v1.30.0Changes:
import module(#1213)Full Changelog: google/google-java-format@v1.29.0...v1.30.0
v1.29.0This release contains no formatting changes.
The minimum support JDK version to run google-java-format is now JDK 21. Using google-java-format to format earlier versions of the language is still fully supported, but running the formatter itself on JDK 21 or newer is required.
Full Changelog: google/google-java-format@v1.28.0...v1.29.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.